Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapr Resource Schema Update #1757

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

kachawla
Copy link
Contributor

@kachawla kachawla commented Sep 6, 2024

Updating dapr samples to reflect the schema update merged in radius-project/radius#7823.

Issue #1756

@kachawla kachawla requested review from rynowak and ytimocin September 6, 2024 02:33
@kachawla kachawla changed the base branch from v0.37 to edge September 6, 2024 02:34
More context: radius-project/radius#7823

Signed-off-by: karishma-chawla <[email protected]>
@kachawla
Copy link
Contributor Author

kachawla commented Sep 6, 2024

Looks like some env var updates were missed causing failures: https://github.com/radius-project/samples/blob/edge/samples/eshop/services/web.bicep#L116-L131 and https://github.com/radius-project/samples/blob/edge/samples/eshop/services/webhooks.bicep#L106-L115. Going to update them and include in this PR.

Related to: #1742

Signed-off-by: karishma-chawla <[email protected]>
@kachawla
Copy link
Contributor Author

kachawla commented Sep 6, 2024

Looks like some env var updates were missed causing failures: https://github.com/radius-project/samples/blob/edge/samples/eshop/services/web.bicep#L116-L131 and https://github.com/radius-project/samples/blob/edge/samples/eshop/services/webhooks.bicep#L106-L115. Going to update them and include in this PR.

Everything is finally green!

@kachawla kachawla merged commit 979fd74 into radius-project:edge Sep 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants